Fix potential bitmap leaks in FrameTimingsObserver#55652
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Fix potential bitmap leaks in FrameTimingsObserver#55652huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Address missing `recycle()` calls for bitmaps in frame timing screenshot capture on Android, which could leak either on exceptions or when window dimensions change. Changelog: [Internal] Differential Revision: D93863311
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 3918dd1. |
Collaborator
|
This pull request was successfully merged by @huntie in 3918dd1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Address missing
recycle()calls for bitmaps in frame timing screenshot capture on Android, which could leak either on exceptions or when window dimensions change.Changelog: [Internal]
Differential Revision: D93863311